Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update styling [PT-187736835] #146

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: Update styling [PT-187736835] #146

merged 1 commit into from
Jun 21, 2024

Conversation

dougmartin
Copy link
Member

  • Moved Data Trial experiment to the first experiment in the list
  • Changed experiment colors so that the icon colors are specified in the experiment and not in the code
  • Added permanent border around experiment name in header
  • Update time series sensor header to use svg sparkgraph
  • Added input borders in tables

@dougmartin dougmartin requested a review from pjanik June 20, 2024 14:19
@dougmartin dougmartin force-pushed the 187736835-time-series-styling-2024-06-20 branch 4 times, most recently from 2d11532 to fb11ce7 Compare June 20, 2024 17:20
@dougmartin
feat: Update styling [PT-187736835]
e474919 
- Moved Data Trial experiment to the first experiment in the list
- Changed experiment colors so that the icon colors are specified in the experiment and not in the code
- Added permanent border around experiment name in header
- Update time series sensor header to use svg sparkgraph
- Added input borders in tables
- Added (optional) placeholders with simple variable substitution for inputs
@dougmartin dougmartin force-pushed the 187736835-time-series-styling-2024-06-20 branch from fb11ce7 to e474919 Compare June 20, 2024 17:39
pjanik
pjanik approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dougmartin dougmartin merged commit abe94eb into master Jun 21, 2024
5 checks passed
@dougmartin dougmartin deleted the 187736835-time-series-styling-2024-06-20 branch June 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanik pjanik pjanik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougmartin @pjanik